This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Catch ASG error of failing to upload WAF policy #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoqin-github
force-pushed
the
waf-upload
branch
from
f597607 to
7e21708
Compare
zhaoqin-github
requested review from
zongzw,
jikui,
zhang-shengping and
Niklaus-xie
zhaoqin-github
changed the title
zhaoqin-github
force-pushed
the
waf-upload
branch
4 times, most recently
from
6953d1c to
ef079bc
Compare
zhaoqin-github
force-pushed
the
waf-upload
branch
from
ef079bc to
7efe7f0
Compare
zhaoqin-github
changed the title
zongzw
reviewed
Nov 18, 2019
Comment on lines
+230
to
+234
| if (error.code === 404) { | ||
| throw new HttpErrors.NotFound(`ASG error: ${error.message}`); | ||
| } else { | ||
| throw new HttpErrors.UnprocessableEntity(`ASG error: ${error.message}`); | ||
| } |
There was a problem hiding this comment.
ASG error may be not accurate. How do we know if fails because of ASG not because of some reason else.
Furthermore, I think this change's benefit is adding ${error.message} in the error response. if (error.code === 404) is useless.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.